Skip to content

move external clients to lib/llm #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

seanmcguire12
Copy link
Member

@seanmcguire12 seanmcguire12 commented Apr 23, 2025

why

  • move external clients to lib/llm with other clients

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: be32f89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR reorganizes the codebase by moving external LLM client implementations from examples/external_clients to lib/llm for better export management and organization.

  • Double forward slash in import path @/lib/llm//aisdk in evals/llm_clients/hn_aisdk.ts needs to be fixed
  • Potential invalid model identifier gpt-4o-mini used in evals/llm_clients/hn_langchain.ts
  • Duplicate image warning messages in lib/llm/customOpenAI.ts should be consolidated
  • JSON parsing in lib/llm/customOpenAI.ts needs better error handling
  • Token usage reporting in lib/llm/langchain.ts could be improved beyond default 0 values

10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant