Skip to content

fix for rare failure on some motorola devices #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix for rare failure on some motorola devices #28

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66b0227
added try catch block for finding element of modal class which is ope…
Aug 4, 2021
5a5a065
finding element by x path of div I agree
Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/test/java/com/browserstack/SingleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,27 @@

import org.testng.Assert;
import org.testng.annotations.Test;
import org.openqa.selenium.JavascriptExecutor;

public class SingleTest extends BrowserStackTestNGTest {

@Test
public void test() throws Exception {
driver.get("https://www.google.com/ncr");
try {
WebElement ele = driver.findElement(By.className("IKl7Q"));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't these ids are generated by the framework at runtime and can change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I have updated the code to find the element.

if(ele.isDisplayed()) {
((JavascriptExecutor)driver).executeScript("arguments[0].scrollTo(0, arguments[0].scrollHeight)",ele);
driver.findElement(By.xpath("//*[@id='L2AGLb']/div")).click();
Copy link

@rchougule rchougule Aug 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these classnames and ids might change in the future with their deploys since they are generated for creating unique values from original classnames (to prevent collision)

Will require some other selectors.

}
}
catch(Exception e){
System.out.print(e);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this print the actual message or just tell the object type is of exception class?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will print this kind of message
org.openqa.selenium.NoSuchElementException: no such element: Unable to locate element: {"method":"xpath","selector":"//div[text()='I agree']"}

}
WebElement element = driver.findElement(By.name("q"));
element.sendKeys("BrowserStack");
element.submit();
Thread.sleep(5000);

Assert.assertEquals("BrowserStack - Google Search", driver.getTitle());
}
}