Strip prefixes in file names #10650
Merged
Strip prefixes in file names #10650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow codegen to remove certain prefixes from source file paths when printing the paths in generated files. This currently is only applied to the `OUT_DIR` and allows generated code to be deterministic.
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Apr 23, 2025
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow codegen to remove certain prefixes from source file paths when printing the paths in generated files. This currently is only applied to the
OUT_DIRand allows generated code to be deterministic.This resolves #10639 and the issue with comments mentioned in #9553. It is a variation on the solution proposed in #9580 (instead of removing prefixes when printing names, they are removed in the constructor
Files::from_paths).