Skip to content

Let external safewalk handle being safe. #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 1.19.4
Choose a base branch
from

Conversation

Murat65536
Copy link
Contributor

@Murat65536 Murat65536 commented May 7, 2025

@ZacSharp
Copy link
Collaborator

ZacSharp commented May 7, 2025

Sorry, I do not think this is a good idea. Pressing shift while placing is needed to avoid interacting with blocks (will change in most cases once I finish #4705) and in the second case you disable forward movement for whatever reason, which, according to the comment there, will make it get stuck in some cases.

@Murat65536 Murat65536 closed this May 7, 2025
@Murat65536 Murat65536 deleted the safewalk-update branch May 7, 2025 14:18
@ZacSharp
Copy link
Collaborator

Actually, I forgot about this:

* Assume safe walk functionality; don't sneak on a backplace traverse.
* <p>
* Warning: if you do something janky like sneak-backplace from an ender chest, if this is true
* it won't sneak right click, it'll just right click, which means it'll open the chest instead of placing
* against it. That's why this defaults to off.

So I'd say if you remove the movement change (or explain why it is needed and doesn't break things) this is fine and #4705 can then reintroduce sneaking in some cases and remove the warning.

@Murat65536 Murat65536 restored the safewalk-update branch May 12, 2025 10:55
@Murat65536 Murat65536 reopened this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants