Skip to content

updates to curated-data #29593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

bribrothers
Copy link
Contributor

added:

nuget/nuget/-/Microsoft.VSSDK.BuildTools/17.0.2122-preview2
nuget/nuget/-/Microsoft.Windows.SDK.Win32Docs/0.1.42-alpha
nuget/nuget/-/Microsoft.Windows.WDK.Win32Metadata/0.12.8-experimental
nuget/nuget/-/MyAwesomeLibrary/1.0.0
nuget/nuget/-/Castle.Core/2.5.1
nuget/nuget/-/NLog/1.0.0.505

Copy link
Member

@capfei capfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files being added are missing the file extension and two licenses need to be updated.

revisions:
0.1.42-alpha:
licensed:
declared: OTHER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs be updated to LicenseRef-scancode-ms-windows-sdk-win10-net-6. Also, the file is missing the .yaml extension.

revisions:
0.12.8-experimental:
licensed:
declared: OTHER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to LicenseRef-scancode-ms-windows-sdk-win10-net-6 and is missing the .yaml file extension.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .yaml file extension

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .yaml file extension

Copy link
Member

@capfei capfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .yaml extension:

  • Microsoft.Windows.SDK.Win32Docs
  • Microsoft.Windows.WDK.Win32Metadata
  • Microsoft.VSSDK.BuildTools
  • MyAwesomeLibrary

Updated license to LicenseRef-scancode-ms-windows-sdk-win10-net-6:

  • Microsoft.Windows.SDK.Win32Docs
  • Microsoft.Windows.WDK.Win32Metadata

@capfei
Copy link
Member

capfei commented Apr 3, 2025

@bribrothers Thank you for the contribution! I have requested some changes. Once completed, I will merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants