TUN-9333: Fix cloudflared tunnel secret rotate #5587
+51
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmpn
approved these changes
May 15, 2025
chungthuang
approved these changes
May 15, 2025
## Summary The tunnel secret is never returned by the API response, therefore, we need to store the tunnel secret and configuration source, sent in the request to update it in the state after the patch is successful.
jcsf
force-pushed
the
joaocarlos/TUN-9333-fix-rotate-secret
branch
from
4f5d017 to
16cbd22
Compare
GoncaloGarcia
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tunnel secret is never returned by the API response, therefore, we need to store the tunnel secret and configuration source, sent in the request to update it in the state after the patch is successful.
Closes #5561