TUN-9253: Fix list cloudflared tunnels optional fields #5589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmpn
approved these changes
May 15, 2025
chungthuang
reviewed
May 15, 2025
internal/services/zero_trust_tunnel_cloudflared/data_source_model.go
Outdated
Show resolved
Hide resolved
jcsf
force-pushed
the
joaocarlos/TUN-9253-fix-list-tunnels-data-source
branch
2 times, most recently
from
91185d8 to
b960cb6
Compare
jcsf
force-pushed
the
joaocarlos/TUN-9253-fix-list-tunnels-data-source
branch
from
b960cb6 to
ccdd6ab
Compare
Previously, fields were parsed before checking if they were set, which could lead to empty value parsing. This change moves parsing after validation to ensure the fields are present.
jcsf
force-pushed
the
joaocarlos/TUN-9253-fix-list-tunnels-data-source
branch
from
ccdd6ab to
7666be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, fields were parsed before checking if they were set, which could lead to empty value parsing. This change moves parsing after validation to ensure the fields are present.
Closes #5524