Skip to content

Revert "Include erb files for analysis, following Flay" #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2016

Conversation

ABaldwinHunter
Copy link
Contributor

This reverts commit 620f2dd.

Roll back functionality in favor of allowing for additional
consideration about configuration/threshold options and tuning
impact on analysis.

@codeclimate/review @noahd1

This reverts commit 620f2dd
in response to seeing duplication issues found on intuitively
small snippets of erb templates.

Roll back to consider configuration/threshold options and tuning.
@ABaldwinHunter
Copy link
Contributor Author

@noahd1 updated commit message:

This reverts commit 620f2dd
in response to seeing duplication issues found on intuitively
small snippets of erb templates.

Roll back to consider configuration/threshold options and tuning.

@gdiggs
Copy link
Contributor

gdiggs commented Jan 29, 2016

LGTM

@noahd1
Copy link
Contributor

noahd1 commented Jan 29, 2016

👍

ABaldwinHunter pushed a commit that referenced this pull request Jan 29, 2016
Revert "Include erb files for analysis, following Flay"
@ABaldwinHunter ABaldwinHunter merged commit 53d93f6 into master Jan 29, 2016
@ABaldwinHunter ABaldwinHunter deleted the abh-revert-erb-files branch January 29, 2016 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants