Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a billing tab to the settings #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add a billing tab to the settings #2811
Changes from 6 commits
f0cd0b9
22a50d9
fdf9480
7646797
ef59d5a
d2a4e06
a744efb
b8e5abe
4586692
492ea65
28c49d4
80fd584
54847e9
fc9bfe3
ff65f50
a23e813
5e42545
e44227a
2324df5
f387a3b
31426ec
c370b91
0fb27af
5fa3c1a
96700ab
324665f
bd80766
ac350c2
bc73fba
547b45b
263cab5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arpan-206 this is something we haven't used before, why is the
#let as ...
needed here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arpan-206 can you explain why this is needed a bit more please? We haven't had to add mirage models manually for other models, and this could cause the fields to go out of sync over time if we aren't careful (no one's going to remember that this needs to be edited every time a charge field is added)