**DO NOT CLOSE** Notification V2 #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang has added a new warning for virtual specifiers on methods of `final` classes. This cleans them up in preparation for enabling that warning. Bug: chromium:403236787 Change-Id: I1bb144494028f674d0de409a65412af1f084b56c Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6391658 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Currently, Chromium openscreen builders are failing for timeout since remote execution is disabled. https://ci.chromium.org/ui/p/openscreen/builders/try/chromium_linux_x64/b8719177567471980433/overview Those builders need to switch from Ninja to Siso. The new properties are necessary for the migration. Bug: 379584977 Change-Id: I52f42dcc247a70cf609e0fcfd6c916ed914ba531 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6436889 Reviewed-by: Mark Foltz <mfoltz@chromium.org>
This patch resolves a longish standing TODO to move the statistics generation code out of the Sender class and into its own, unit tested class. This class is called StatisticsDispatcher. Bug: 298277160 Change-Id: I755beb6c4222f65a94a9b5503a708c431e52bc1b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6398046 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Muyao Xu <muyaoxu@google.com>
The chromium builders don't use Reclient anymore. Bug: 379584977 Change-Id: I2071ea6c93c3af80e19a82dfd93ddf25fbbf5725 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6439985 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Closed
Clang maps -Wall (or /Wall) to -Weverything on windows, so it causes low-value warnings to trigger during out build. Instead, we should use /W4, which corresponds to gcc's `-Wall -Wextra`. Bug: chromium:410803303 Change-Id: Id512338bf412794e4b7278e7b6332bc44fe74305 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6457698 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
This patch improves error messaging around certificate loading, especially private keys. Change-Id: I5c00b44a9bed04ec51826d78805b0cb29f90e855 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6473163 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Muyao Xu <muyaoxu@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack to get commit notifications. Do not close!!!