refactor: strip possessive from note about ci option #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A description of the commit option affecting the ci does not require a "our", nor "your". It doesn't relate to "a local" vs. "a remote repository", either. To ease conveying the intent,[1] the possessive is removed. [1] #1095 Signed-off-by: Norwid Behrnd <nbehrnd@yahoo.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
+ Coverage 97.33% 97.54% +0.20%
==========================================
Files 42 55 +13
Lines 2104 2486 +382
==========================================
+ Hits 2048 2425 +377
- Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lee-W
approved these changes
May 14, 2024
|
closes: #1095 |
|
Plan to merge it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A description of the commit option affecting the ci does not require a "our", nor "your". It doesn't relate to "a local" vs. "a remote repository", either. To ease conveying the intent,[1] the possessive is removed.
[1] #1095
Description
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
In commit option
ci: Changes to our CI configuration ..., the possessive does not provide additional clarity. Hence the suggest to remove it from this entry.Steps to Test This Pull Request
Following the outline of
/commitizen/docs/contributing.md, and after the local commit, I launched./scripts/format, then./scripts/test. They close byabout checks by pytest, and
Commit validation: successful!by the later.Additional context