refactor(changelog): cleanup and add test cases #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
force-pushed
the
refactor-changelog-2
branch
from
a8be6cc to
9bb9ed9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 97.33% 97.57% +0.23%
==========================================
Files 42 57 +15
Lines 2104 2675 +571
==========================================
+ Hits 2048 2610 +562
- Misses 56 65 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
refactor-changelog-2
branch
2 times, most recently
from
b3dac29 to
949b496
Compare
bearomorphism
commented
May 17, 2025
| def test_get_smart_tag_range_returns_an_empty_list_for_nonexistent_start_tag(tags): | ||
| end = tags[0] | ||
| res = changelog.get_smart_tag_range(tags, "nonexistent", end.name) | ||
| assert res[0].name == tags[1].name |
There was a problem hiding this comment.
Not sure if this is the expected behavior
bearomorphism
force-pushed
the
refactor-changelog-2
branch
from
1d03ae8 to
12166d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context