Skip to content

feat!: Back to the feature! #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DoppioJP
Copy link

The 'feat' word means something different than the word 'feature'

feat | fiːt |
noun
an achievement that requires great courage, skill, or strength: the new printing presses were considerable feats of engineering.

Fixes #544

BREAKING CHANGE: I think this will break some tools and for sure some memory muscles

The 'feat' word means something different than the word 'feature'

BREAKING CHANGE: I think this will break some tools and for sure some
memory muscles
@LemmingAvalanche
Copy link

Why not make it a synonym? That wouldn’t break anything.

@DoppioJP
Copy link
Author

DoppioJP commented Apr 2, 2024

Why not make it a synonym? That wouldn’t break anything.

Neat idea @LemmingAvalanche. How could I make it a synonym. I was looking for synonym references in this codebase, but I could not find anything I could use for this very purpose.

@LemmingAvalanche
Copy link

LemmingAvalanche commented Apr 3, 2024

@DoppioJP

How could I make it a synonym.

Change the text to something like

**feat** or **feature:** a commit of the _type_ `feat` or `feature` introduces 
a new feature to the codebase. `feature` is preferred over `feat`.

I guess.

@bcoe
Copy link
Member

bcoe commented May 2, 2025

The 'feat' word means something different than the word 'feature'

I appreciate this argument 👏 but, at this point Conventional Commits has been around for like 10 years, there are lots of tools built around it that assume feat:. And, independently of the dictionary definition, feat: has taken on its own meaning, in relation to commit conventions.

Also, the definition "an achievement that requires great courage, skill, or strength: the new printing presses were considerable feats of engineering.", is a feature! How much better does it feel to land a PR in your repository, when you view it as an achievement of great courage?

I appreciate this PR, but this is not something we'll change in the main repository.


I don't think we need a process quite as structured as proposed by #537, but I also think it would be worth adding a section to the document about extending and making changes to conventional commits.

I see no reason why your team couldn't use feature rather than feat for your PRs, as long as it's documented. The trade off, is there may be some tools in the community like release-please that don't work out of the box.

@bcoe bcoe closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat is contracted, most other commonly used tags are full words.
3 participants