Skip to content

feat: add Persian language, RTL support, and custom fonts #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aminfo184
Copy link

  • Added Persian translation
  • Improved RTL styles
  • Added custom fonts for Persian and English

- Added Persian translation
- Improved RTL styles
- Added custom fonts for Persian and English
@bcoe
Copy link
Member

bcoe commented May 2, 2025

@aminfo184 I missed this PR and merged #642, is it worth bringing over some of your changes (such as the alternate fonts) in a new PR?

@bcoe
Copy link
Member

bcoe commented May 2, 2025

@aminfo184 also, looking at your PR, should the country code be changed to fa?

@aminfo184
Copy link
Author

@bcoe Hey! Thanks for taking a look! 😄 In PR #638, I used the fa code for Persian since it’s super standard and spot-on (per ISO 639-1). The main focus of this PR is the smooth translation, clean RTL styles, and awesome custom fonts. I think these came out way better in PR #638 compared to PR #642, and they’ll be a lot more exciting for Persian and RTL users! 😎
Could you please revert #642 and merge this PR It’ll save time and make the project look awesome. Happy to help with anything you need! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants