Skip to content

fix(cubesql): Disable filter pushdown over Filter(CrossJoin) #9474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This should help with rewrites filters on top of complex ungrouped-grouped joins as a subquery joins

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (85c27a9) to head (4d9020c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9474      +/-   ##
==========================================
- Coverage   80.31%   80.27%   -0.04%     
==========================================
  Files         395      395              
  Lines       97349    97355       +6     
  Branches     2278     2278              
==========================================
- Hits        78181    78150      -31     
- Misses      18860    18897      +37     
  Partials      308      308              
Flag Coverage Δ
cube-backend 57.50% <ø> (ø)
cubesql 83.93% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov marked this pull request as ready for review April 15, 2025 16:25
@mcheshkov mcheshkov requested a review from a team as a code owner April 15, 2025 16:25
@ovr ovr requested a review from MazterQyou April 23, 2025 16:53
This should help with rewrites filters on top of complex ungrouped-grouped joins as a subquery joins
@mcheshkov mcheshkov force-pushed the filter-pushdown-vs-join branch from 8826ccc to 4d9020c Compare April 28, 2025 13:18
@mcheshkov mcheshkov merged commit 940c30f into master Apr 28, 2025
72 checks passed
@mcheshkov mcheshkov deleted the filter-pushdown-vs-join branch April 28, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants