Skip to content
This repository was archived by the owner on May 27, 2022. It is now read-only.

Modify the kafka initialized blocking problem #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify the kafka initialized blocking problem #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/github/danielwegener/logback/kafka/KafkaAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class KafkaAppender<E> extends KafkaAppenderConfig<E> {
* Kafka clients uses this prefix for its slf4j logging.
* This appender defers appends of any Kafka logs since it could cause harmful infinite recursion/self feeding effects.
*/
private static final String KAFKA_LOGGER_PREFIX = "org.apache.kafka.clients";
private static final String KAFKA_LOGGER_PREFIX = "org.apache.kafka";

private LazyProducer lazyProducer = null;
private final AppenderAttachableImpl<E> aai = new AppenderAttachableImpl<E>();
Expand All @@ -44,10 +44,10 @@ public KafkaAppender() {

@Override
public void doAppend(E e) {
ensureDeferredAppends();
if (e instanceof ILoggingEvent && ((ILoggingEvent)e).getLoggerName().startsWith(KAFKA_LOGGER_PREFIX)) {
deferAppend(e);
} else {
ensureDeferredAppends();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could produce a memory leak as long as the queue is unbounded :/

super.doAppend(e);
}
}
Expand Down