Skip to content

Tweak tooltip configuration #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Tweak tooltip configuration #1801

merged 2 commits into from
Feb 24, 2025

Conversation

DannyDelott
Copy link
Contributor

The list of pools contains roughly 50 different popovers (~2 per row), which is triggering a Max update depth exceeded error from React.

This is well documented in Radix as a problem, but has no known solution:
radix-ui/primitives#2152
radix-ui/primitives#2717

So this PR isn't guaranteed to fix the issue, however some have suggested updating to the latest React 18 version (good to do this anyways!).

Additionally, I noticed we were creating a new Tooltip.Provider for each tooltip that gets rendered, instead of a single one at the top of our application. Hopefully this is is a step in the right direction, but only time will tell!

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:12pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 7:12pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Feb 24, 2025 7:12pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Feb 24, 2025 7:12pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Feb 24, 2025 7:12pm
testnet-v1 ⬜️ Ignored (Inspect) Feb 24, 2025 7:12pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Feb 24, 2025 7:12pm
trading-competition ⬜️ Ignored (Inspect) Feb 24, 2025 7:12pm

Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: 2ca3727

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DannyDelott DannyDelott merged commit d070a96 into main Feb 24, 2025
15 checks passed
@DannyDelott DannyDelott deleted the danny-tooltip-tweaks branch February 24, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants