Tweak tooltip configuration #1801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of pools contains roughly 50 different popovers (~2 per row), which is triggering a
Max update depth exceeded
error from React.This is well documented in Radix as a problem, but has no known solution:
radix-ui/primitives#2152
radix-ui/primitives#2717
So this PR isn't guaranteed to fix the issue, however some have suggested updating to the latest React 18 version (good to do this anyways!).
Additionally, I noticed we were creating a new
Tooltip.Provider
for each tooltip that gets rendered, instead of a single one at the top of our application. Hopefully this is is a step in the right direction, but only time will tell!