Skip to content

Install floating-ui, refactor RewardsTooltip #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2025

Conversation

DannyDelott
Copy link
Contributor

@DannyDelott DannyDelott commented Mar 10, 2025

This PR refactors over to @floating-ui/react from @radix-ui/tootltip. We are making the switch because radix-ui crashes the UI due to the high number of tooltips we need to render at a time.

image

Radix-ui has been made aware, but there is no fix or workaround as of this writing. Here are the related issues:

radix-ui/primitives#2152
radix-ui/primitives#2717

Additionally, after rebasing #1820 I needed to rebuild hyperdrive-wasm and fixed-point-wasm, hence the checked in files there.

Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 02dfbcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:03pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 7:03pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 7:03pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 7:03pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 7:03pm
testnet-v1 ⬜️ Ignored (Inspect) Mar 10, 2025 7:03pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 7:03pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 7:03pm

@DannyDelott DannyDelott merged commit 6dc9a41 into main Mar 10, 2025
15 checks passed
@DannyDelott DannyDelott deleted the danny-update-reward-tooltip-component branch March 10, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants