Skip to content

Edit pass #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2023
Merged

Edit pass #322

merged 2 commits into from
Oct 23, 2023

Conversation

bamurtaugh
Copy link
Member

Edit pass similar to what I opened for containers.dev: devcontainers/devcontainers.github.io#307

A few additional questions:

  • Is there a reason we don't have Templates documentation in the specs folder? cc @samruddhikhandale
  • I think we could explore using Bikeshed as the user described in Consider using something like Bikeshed? #293 (comment), though this would be a pretty major change to both the spec repo and containers.dev / its backing repo
    • I'm not 100% if it's worth the potentially great overhead (to begin with at least), since we're no longer at a point where we're making huge changes to the spec all the time
    • I'm open to other thoughts here

@bamurtaugh bamurtaugh requested a review from a team as a code owner October 20, 2023 21:13
@samruddhikhandale
Copy link
Member

@bamurtaugh Feel free to move https://github.com/devcontainers/spec/blob/main/proposals/devcontainer-templates.md and https://github.com/devcontainers/spec/blob/main/proposals/devcontainer-templates-distribution.md to the spec folder.

@bamurtaugh
Copy link
Member Author

Done!

samruddhikhandale
samruddhikhandale approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@bamurtaugh bamurtaugh merged commit a2e4b49 into main Oct 23, 2023
@bamurtaugh bamurtaugh deleted the bamurtaugh/edit-pass branch October 23, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bamurtaugh @samruddhikhandale