-
Notifications
You must be signed in to change notification settings - Fork 6
fix: Add styling for bare django admin #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request addresses styling issues in the django CMS admin interface when no custom admin styles are applied. It introduces fallback CSS variable values for background, border, and shadow colors, ensuring a consistent look with the default Django admin. Additionally, it sets the font-family for dialog and menubar elements and adjusts the padding of the edit toggle button in the CMS toolbar. Updated class diagram for CSS variablesclassDiagram
class CSSVariables {
<<Static>>
--dca-white: string
--body-bg: string
--dca-gray-light: string
--close-button-bg: string
--dca-shadow: string
--body-fg: string
--font-family-primary: string
--dca-gray-lighter: string
--boder-color: string
--darkened-bg: string
--dca-gray: string
--body-quiet-color: string
--dca-primary: string
--parimary: string
}
note for CSSVariables "This diagram shows the CSS variables that have been updated with fallback values in this PR."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fsbraun - I've reviewed your changes - here's some feedback:
Overall Comments:
- It might be worth adding a comment explaining the fallback values being used here.
- Consider adding a test case that specifically covers the scenario where djangocms-admin-style is not installed.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 81.30% 81.30%
=======================================
Files 18 18
Lines 952 952
Branches 107 107
=======================================
Hits 774 774
Misses 135 135
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This PR ensures the correct color styling for plain admin styling (i.e., no djangocms-admin-style or djangocms-simple-admin-style).
Summary by Sourcery
Add fallback styling for bare Django admin to ensure consistent appearance across different admin style configurations
Bug Fixes:
Enhancements:
Chores: