Skip to content

fix: Add styling for bare django admin #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Add styling for bare django admin #75

wants to merge 4 commits into from

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Apr 10, 2025

This PR ensures the correct color styling for plain admin styling (i.e., no djangocms-admin-style or djangocms-simple-admin-style).

Summary by Sourcery

Add fallback styling for bare Django admin to ensure consistent appearance across different admin style configurations

Bug Fixes:

  • Ensure proper color and styling when no custom admin style is applied

Enhancements:

  • Modify CSS variables to include fallback values for default Django admin styling
  • Add default font family for toolbar and dialog elements

Chores:

  • Update CSS to be more robust across different admin style configurations

Copy link
Contributor

sourcery-ai bot commented Apr 10, 2025

Reviewer's Guide by Sourcery

This pull request addresses styling issues in the django CMS admin interface when no custom admin styles are applied. It introduces fallback CSS variable values for background, border, and shadow colors, ensuring a consistent look with the default Django admin. Additionally, it sets the font-family for dialog and menubar elements and adjusts the padding of the edit toggle button in the CMS toolbar.

Updated class diagram for CSS variables

classDiagram
    class CSSVariables {
        <<Static>>
        --dca-white: string
        --body-bg: string
        --dca-gray-light: string
        --close-button-bg: string
        --dca-shadow: string
        --body-fg: string
        --font-family-primary: string
        --dca-gray-lighter: string
        --boder-color: string
        --darkened-bg: string
        --dca-gray: string
        --body-quiet-color: string
        --dca-primary: string
        --parimary: string
    }
    note for CSSVariables "This diagram shows the CSS variables that have been updated with fallback values in this PR."
Loading

File-Level Changes

Change Details Files
Updated CSS variables for background, border, and shadow colors to ensure compatibility with default Django admin styling when custom admin styles are not in use.
  • Modified background colors to fallback to var(--body-bg, #fff) if --dca-white is not defined.
  • Modified border colors to fallback to var(--close-button-bg, #888) or var(--boder-color, #ccc) if --dca-gray-light or --dca-gray-lighter are not defined, respectively.
  • Modified shadow colors to fallback to var(--body-fg, #000) if --dca-shadow is not defined.
  • Modified text color for fake selection to fallback to HighlightText.
djangocms_text/static/djangocms_text/css/cms.text.css
private/css/cms.linkfield.css
private/css/cms.tiptap.css
Added font-family to dialog and menubar elements to ensure consistent text rendering.
  • Added font-family: var(--font-family-primary, Helvetica, Arial, sans-serif); to dialog.cms-form-dialog.
  • Added font-family: var(--font-family-primary, Helvetica, Arial, sans-serif); to [role="menubar"].
djangocms_text/static/djangocms_text/css/cms.text.css
private/css/cms.toolbar.css
Adjusted padding for the edit toggle button in the CMS toolbar.
  • Added padding-top: 12.5%; to #cms-top .cms-toolbar .cms-edit-toggle.
djangocms_text/static/djangocms_text/css/cms.text.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It might be worth adding a comment explaining the fallback values being used here.
  • Consider adding a test case that specifically covers the scenario where djangocms-admin-style is not installed.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (632bf2e) to head (3db31c8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   81.30%   81.30%           
=======================================
  Files          18       18           
  Lines         952      952           
  Branches      107      107           
=======================================
  Hits          774      774           
  Misses        135      135           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fsbraun and others added 3 commits April 10, 2025 22:42
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant