-
Notifications
You must be signed in to change notification settings - Fork 6
feat: extend tiptap table to have a (configurable) class attribute #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request extends the Tiptap table extension to allow for configurable class attributes. It introduces a new Sequence diagram for inserting a table with a classsequenceDiagram
participant Editor
participant Toolbar
participant Chain
participant TableNode
Toolbar->>Editor: User clicks table button with class
Editor->>Chain: chain()
Chain->>Chain: focus()
Chain->>Chain: insertTable({rows, cols})
Chain->>Chain: updateAttributes('table', {class})
Chain->>Chain: run()
Chain-->>TableNode: Creates and inserts table node with class attribute
Editor-->>Toolbar: Updates editor view
Updated class diagram for the Table extensionclassDiagram
class Table {
+resizable: boolean
+HTMLAttributes: Object
}
class ExtendedTable {
+attributes: Object
+class: string|null
+addAttributes()
}
Table <|-- ExtendedTable
note for ExtendedTable "Allows individual tables to have custom CSS classes applied"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 81.30% 81.30%
=======================================
Files 18 18
Lines 952 952
Branches 107 107
=======================================
Hits 774 774
Misses 135 135
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #78
This PR allows to add class attributes to tables.
Summary by Sourcery
Extend Tiptap table extension to support configurable class attributes for tables
New Features:
Enhancements:
Chores: