chore(tiering): Test utils for faulty io #4928
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
dranikpg-faulty-tiering-io
branch
from
0134534 to
7938f78
Compare
romange
reviewed
Apr 13, 2025
| @@ -0,0 +1,46 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
wow, this is cool!
how did you find this? chatgpt?
There was a problem hiding this comment.
I'm too old for that 👴🏻 Googling
https://unix.stackexchange.com/questions/77492/special-file-that-causes-i-o-error
romange
reviewed
Apr 13, 2025
| @@ -80,7 +80,7 @@ error_code DiskStorage::Open(string_view path) { | |||
| backing_file_ = std::move(res.value()); | |||
|
|
|||
| int fd = backing_file_->fd(); | |||
| RETURN_ON_ERR(DoFiberCall(&SubmitEntry::PrepFallocate, fd, 0, 0L, kInitialSize)); | |||
| DoFiberCall(&SubmitEntry::PrepFallocate, fd, 0, 0L, kInitialSize); | |||
There was a problem hiding this comment.
why did you remove the return?
There was a problem hiding this comment.
Not all filesystems support fallocate
There was a problem hiding this comment.
Grow() will fail as well, otherwise it's ok to just write past file boundaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial prototype for creating faulty mountpoints to test tiering with spontaneous io errors