Adds a set to refactor service names to interfaces/classes #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
force-pushed
the
feature/refactor-service-container-arg
branch
from
6293775 to
f22c2c9
Compare
|
We could call out extra features in the readme rather than a separate md file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
This will make it easier for people to clean up an app with the old-style strings used and replace them with appropriate references to interfaces or if not an interface, the class itself.
Notes
The only problem I can see currently is there are no docs for these and this is a problem for #184 as well, people won't know these exist without extra documentation. I don't know if an extra markdown file that's just manually updated will do for now.