feat(message): Add notification functionality #241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: components/message/message.module.ts demo/src/app/pages/test/test.page.html demo/src/app/pages/test/test.page.ts
Messages are now completely controlled within the component, rather than trying to tack on functionality to the existing messages
BREAKING CHANGE
…pty bar Added `transition` Added `transitionDuration` Added `canCompletelyEmpty`
Since they're both behind public filtered interfaces there isn't any need to keep them private
|
ping @mcosta74 @harogaston been sitting on this one for a while, if either of you get a moment, build this and go to the test component to play around. It's pretty much complete, just needs tweaking. |
|
btw because of the merge the diff is insanely big... do you know how to make that not happen? Can't work it out |
edcarroll
force-pushed
the
feat(message)/notification-functionality
branch
from
f99b4c7 to
4491f15
Compare
edcarroll
force-pushed
the
feat(message)/notification-functionality
branch
from
f99b4c7 to
4491f15
Compare
|
Closing in favor of #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is WIP
This PR adds toast style notifications to the message components, as outlined in #103.
Will update this comment with more info when I have more time.