-
Notifications
You must be signed in to change notification settings - Fork 40
feat: add support for packaging fiddles as ASAR using @electron/asar #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for packaging fiddles as ASAR using @electron/asar #138
Conversation
d24be4b
to
c97f17c
Compare
c97f17c
to
c791fab
Compare
Hi @erickzhao, just a friendly reminder for a review when you have a moment. |
Pushed up a few commits here due to the main branch being fixed (3b420d8) and to re-commit the lockfile due to our internal policies around that. |
This looks like a good start, but I think some changes are needed before we can merge. I've left a comment about the |
Added a test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close, just a few more comments. Be sure to run yarn docs
after the final changes to ensure that etc/fiddle-core.api.md
is up-to-date.
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
option
parameter inFiddleFactory.create()
method.{ packAsAsar: true }
is passed asoption
, the fiddle is packaged as an ASAR using@electron/asar.
Closes #100