Improve clarity of example comments #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Sep 6, 2024
Comment on lines
-39
to
40
| /* when Array#findLastIndex is not present */ | ||
| /* when Array#findLastIndex is present */ | ||
| delete Array.prototype.findLastIndex; |
There was a problem hiding this comment.
the comment refers to the .shim() call being made when it's not present. the delete is so that evalmd doesn't fail in an engine where it is present.
Comment on lines
-50
to
51
| /* when Array#findLastIndex is present */ | ||
| /* when Array#findLastIndex is not present */ | ||
| var shimmed = findLastIndex.shim(); |
There was a problem hiding this comment.
similarly, it's present here for this shim() call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ljharb, hope things are good with you!
Reading the comments in the readme examples left me a bit confused - if
Array.prototype.findLastIndexis not present, then why would it need to be deleted? I swapped "not present" and "present" in the examples, in case my understanding is correct.Alternatives considered: maybe I'm misunderstanding the comment and it is indeed correct as it is