Skip to content

Replace ethers with viem in vm examples/tests #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Apr 21, 2025

ethers currently is using an older version of @noble/hashes (v1.3.2) which is causing some duplication of versions of @noble/hashes in our monorepo.

ethers is only being used in vm for some ABI encoding/decoding utilities in 2 examples and one test so this replaces it with viem which has no dependencies and provides basically drop-in replacements for those tools.

Note, the robots wrote the actual translations of these functions and I reviewed/edited/tightened things up.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (77bf2e9) to head (4629c81).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 83.34% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.95% <ø> (ø)
common 97.51% <ø> (ø)
devp2p 86.78% <ø> (ø)
evm 73.03% <ø> (ø)
mpt 89.45% <ø> (ø)
statemanager 69.08% <ø> (ø)
static 99.11% <ø> (ø)
tx 90.59% <ø> (ø)
util 89.53% <ø> (ø)
vm 55.27% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acolytec3 acolytec3 marked this pull request as draft April 21, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants