Client: (WIP) rework CLI startup logic using RpcConfig (#3983) #4013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts addressing #3983 by refactoring the client CLI
Description
RpcConfig
class for RPC endpoints (eth/engine, http/ws)generateRpcConfigs()
func to generate all server configurations from CLI argsstartRPCServers()
to use these configs instead of cli argsrun()
function to improve testability:run()
now handles only CLI argument parsing, config generation, and dispatchstartClientAndServers()
function performs the client and RPC server startupThis is still a work in progress — if the current structure looks good, I’ll follow up with unit tests for the new helpers and config logic in a separate commit!