Skip to content

util: refactor 7702 authorization lists to util package #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 26, 2025

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Apr 25, 2025

This refactors the authorization lists helpers, types and tests from the tx package to util.
I have also changed the API so that it directly accepts a custom ecsign instead of accepting it through a passed Common instance

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.51%. Comparing base (30c2491) to head (c2406ee).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.99% <ø> (ø)
common 97.51% <ø> (ø)
devp2p 86.78% <ø> (ø)
evm 73.11% <ø> (ø)
mpt 89.74% <ø> (+0.05%) ⬆️
statemanager 69.06% <ø> (ø)
static 99.11% <ø> (ø)
tx 89.89% <100.00%> (-0.71%) ⬇️
util 89.19% <70.58%> (-0.17%) ⬇️
vm 55.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 17852b5 into master Apr 26, 2025
39 of 40 checks passed
@acolytec3 acolytec3 deleted the refactor/auth-list-utils branch April 26, 2025 12:03
@holgerd77
Copy link
Member

Ah, yeah, that's a lot better. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants