Improve e2store README #4035
Merged
Improve e2store README #4035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ScottyPoi
force-pushed
the
e2store-README
branch
from
a04684b to
9896dfb
Compare
holgerd77
reviewed
Apr 26, 2025
|
|
||
| // Read Beacon Blocks from era file | ||
| let count = 0 | ||
| for await (const block of readBlocksFromEra(eraFile)) { | ||
| console.log(block.message.slot) | ||
| console.log(`Block slot: ${block.message.slot}`) | ||
| count++ | ||
| if (count > 10) break | ||
| } |
There was a problem hiding this comment.
Nice, can we also add all the examples from the README to a dedicated examples folder so that they are auto-inserted from now on when npm run build:examples is run?
So, the way that this works is that you add the comment line (and you can leave the example code itself in first round) from the screenshot below in the README example block(s):
And when you then run the npm command (and code is not yet there) you can test if the stuff is inserted automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates package README