displacy: fix import path for ipython 9.0.1 #13762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Degawa <ccom@randomderp.com>
|
You may close this PR since the same fix #13787 is progressing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With IPython 9.0.1, they removed the
IPython.core.displayshim thatdisplacy.render()relied on. This was apparently deprecated in IPython 8.0.0.This fixes it by trying the newer import path if possible, falling back to the older one.
Types of change
Bug fix
Checklist
I am unable to install the packages in requirements.txt due to
thinc<8.4.0,>=8.3.4being unsatisfied since there's only nearby version 8 package is8.3.2and then it skips to9.0.0.dev0. However, editing this line locally fixed the import issue.