-
Notifications
You must be signed in to change notification settings - Fork 52
Component | Plotband: Add plotband component #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@rokotyan . |
I will review this this week (as well as the other PR). Sorry for the delay. |
Thanks for the message. I'm subscribed to these PRs, so in case of any change requests - I'll be online. |
e9358fa
to
88e4666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please sort import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the example to be part of the website, you need to add an entry inexamples-list.tsx
, and add a screenshot in the _previews
folder.
@50rayn started the review, but halfway realized a lot of the things echo what Nikita left in the |
@50rayn build failed. Do you want to take a look? |
Fixed. Missed some files in the examples, like dark preview and .ts file. Now the build is passing. |
In this PR will be added Plotband element in the chart. Since it's a common detail in other libraries, like Highcharts plotband, ECharts markArea etc., I implemented this idea in the current library.