Skip to content

Component | Plotband: Add plotband component #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

50rayn
Copy link
Contributor

@50rayn 50rayn commented May 8, 2025

In this PR will be added Plotband element in the chart. Since it's a common detail in other libraries, like Highcharts plotband, ECharts markArea etc., I implemented this idea in the current library.

2025-05-08 at 12 33 17

@50rayn 50rayn marked this pull request as ready for review May 13, 2025 20:04
@50rayn
Copy link
Contributor Author

50rayn commented May 13, 2025

@rokotyan .
I feel that everything is fine. Is there something more to be added?

@lee00678
Copy link
Collaborator

I feel that everything is fine. Is there something more to be added?

I will review this this week (as well as the other PR). Sorry for the delay.

@50rayn
Copy link
Contributor Author

50rayn commented May 20, 2025

I feel that everything is fine. Is there something more to be added?

I will review this this week (as well as the other PR). Sorry for the delay.

Thanks for the message. I'm subscribed to these PRs, so in case of any change requests - I'll be online.

@50rayn 50rayn force-pushed the feat/plot-band branch 2 times, most recently from e9358fa to 88e4666 Compare May 21, 2025 16:00
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sort import.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the example to be part of the website, you need to add an entry inexamples-list.tsx, and add a screenshot in the _previews folder.

@lee00678
Copy link
Collaborator

@50rayn started the review, but halfway realized a lot of the things echo what Nikita left in the plotline component. Could you please do a round of update here first?

@lee00678
Copy link
Collaborator

@50rayn build failed. Do you want to take a look?

@50rayn
Copy link
Contributor Author

50rayn commented May 28, 2025

@50rayn build failed. Do you want to take a look?

Fixed. Missed some files in the examples, like dark preview and .ts file. Now the build is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants