[prebuild][iOS] building up to React Core #50766

chrfalch · 2025-04-16T16:55:50Z

Summary:

Added multiple targets to Package.swift
WIP: Builds up untill we need to touch files in React/Base

Changelog:

[INTERNAL] - WIP: prebuilding using Swift packages

Test Plan

Build Package.swift in Xcode for now

- Added multiple targets to Package.swift - WIP: Builds up untill we need to touch files in React/Base

- Added scripts for creating hardlinks to resolve headers - Added multiple packages and dependencies

- Added hermes download - Added codegen - Tried resolving some more packages

- now ignores .build

cipolleschi

I still have to go through the Package.swift file, but I'm leaving a few comments on the JS part.

packages/react-native/scripts/ios-prebuild/utils.js

packages/react-native/scripts/ios-prebuild.js

- First it runs codegen - Then it downloads hermes (if needed) - Then it creates hard links

…folders - Now uses fs.linkSync to link each file. This makes the output a bit cleaner as well. - Removed parameter specifying library in codegen.

cipolleschi

Amazing work, thank you so much!

I left a few minor comments on things that might need to be adjusted or that are not needed. And then we can look at how we can simplify the Package.swift. But I'm super happy that we got here!

packages/react-native/scripts/ios-prebuild.js

cipolleschi · 2025-04-29T14:32:51Z

packages/react-native/scripts/ios-prebuild.js

+    link('React/CxxUtils', 'CxxUtils', 'React');
+    link('React/DevSupport', 'DevSupport', 'React');
+    link('React/Inspector', 'Inspector', 'React');
+    link('React/I18n', 'I18n', 'React');


this scares me a little bit. We should verify that i18n keeps working after we build.

Yes, we need to solve including the strings as well - I haven't looked at it yet.

packages/react-native/scripts/ios-prebuild/cli.js

packages/react-native/Package.swift

This target does not need to be built, it is for the app only.

Added abstractions and removed complex include file generation

- Combined hermesprebuilt + hermesIncludes - Removed duplicate include paths to the compiler - Removed version number for hermes in package.swift

- Made deps named and not by reference (due to order of initialization) - Fixed issue in utils.js.

cipolleschi · 2025-05-07T15:17:34Z

packages/react-native/Package.swift

+class RNTarget: BaseTarget {
+  let linkedFrameworks: [String]
+  let excludedPaths: [String]
+  let dependencies: [String]


wouldn't be easier if this is already a [BaseTarget] instead of a [String]?
We already have the targets so we can pass them right into the other targets.

In this way, we can avoid the

let dependencies = self.dependencies.compactMap { depName in targets.first(where: { $0.name == depName }) }

below

Tried it, but there’s a sneaky issue with non-initialized variables that was hard to debug where you can use a non-initialized target before it is declared. Then its name and props aren’t initialized and the dependencies weren’t resolved properly. It could be fixed with changing the order so that we never used an uninitialized target, but the moment someone added a new target and forgot this they’d have to try to find this bug all over again. So I thought it would be safest to use the name we already had to avoid this.

yeah, in this case the order we use to define the variables is important, as it is important with any kind of program. We can keep it like it is for now.

Absolutely :) :) I think I'd just had enough with things I had to look out for at this moment and found going for strings would be safer - and hopefully save us some work in the future.

facebook-github-bot · 2025-05-08T09:03:51Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: This change adds a script to sdownload the hermes artifact and to prepare it for building react Native using SwiftPM bypass-github-export-checks ## Changelog: [INTERNAL] - Add script to download the hermes artifact Pull Request resolved: facebook#50766 Test Plan: This will be tested in a diff in the stack. Differential Revision: D74386522

Summary: - Added multiple targets to Package.swift - WIP: Builds up untill we need to touch files in React/Base ## Changelog: [INTERNAL] - WIP: prebuilding using Swift packages Pull Request resolved: facebook#50766 Test Plan: This will be tested in a diff in the stack. Differential Revision: D74386522

Summary: - Added multiple targets to Package.swift - WIP: Builds up untill we need to touch files in React/Base ## Changelog: [INTERNAL] - WIP: prebuilding using Swift packages Pull Request resolved: facebook#50766 Test Plan: This will be tested in a diff in the stack. Differential Revision: D74386522 Pulled By: cipolleschi

Summary: - Added multiple targets to Package.swift - WIP: Builds up untill we need to touch files in React/Base ## Changelog: [INTERNAL] - WIP: prebuilding using Swift packages Pull Request resolved: facebook#50766 Test Plan: This will be tested in a diff in the stack. Differential Revision: D74386522 Reviewed By: cortinico Pulled By: cipolleschi

facebook-github-bot · 2025-05-08T20:04:05Z

@cipolleschi merged this pull request in 43bfb5d.

react-native-bot · 2025-05-08T20:04:08Z

This pull request was successfully merged by @chrfalch in 43bfb5d

^{When will my fix make it into a release? | How to file a pick request?}

Building up to React/Base

4a0455d

- Added multiple targets to Package.swift - WIP: Builds up untill we need to touch files in React/Base

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2025

chrfalch added 2 commits April 28, 2025 12:47

[ios][prebuild][spm] added more packages and scripts

deed33d

- Added scripts for creating hardlinks to resolve headers - Added multiple packages and dependencies

[ios][prebuild][spm] added hermes download + codegen

737fdc6

- Added hermes download - Added codegen - Tried resolving some more packages

chrfalch changed the title ~~[prebuild][iOS] building up to "React/Base"~~ [prebuild][iOS] building up to React Core Apr 28, 2025

chrfalch added 2 commits April 28, 2025 15:12

[ios][prebuild] more targets and hard links

730e8fb

[ios][prebuild] updated gitignore to ignore new build folder

e617232

- now ignores .build

cipolleschi reviewed Apr 28, 2025

View reviewed changes

packages/react-native/scripts/ios-prebuild/utils.js Outdated Show resolved Hide resolved

packages/react-native/scripts/ios-prebuild.js Outdated Show resolved Hide resolved

packages/react-native/scripts/ios-prebuild.js Outdated Show resolved Hide resolved

chrfalch added 4 commits April 29, 2025 08:42

[ios][prebuild] changed order of steps in script

8550f26

- First it runs codegen - Then it downloads hermes (if needed) - Then it creates hard links

[ios][prebuild] updated script to use hard links to files instead of …

07e3cf6

…folders - Now uses fs.linkSync to link each file. This makes the output a bit cleaner as well. - Removed parameter specifying library in codegen.

[ios][prebuild] added rctfabric, fabriccomponents and fabricimage

fe5ace3

[ios][prebuild] swift package now building

748da87

cipolleschi reviewed Apr 29, 2025

View reviewed changes

chrfalch added 9 commits April 30, 2025 14:37

[ios][prebuild] removed react codegen target

d529472

This target does not need to be built, it is for the app only.

[ios][prebuild] removed linking codegen in js script

c5799ad

[ios][prebuild] Simplification of swift package

31909b4

Added abstractions and removed complex include file generation

Removed exists check

20842da

cleanup

57685cd

Removed trailing commas

78fb60c

Cleanup hermes

ee77a77

- Combined hermesprebuilt + hermesIncludes - Removed duplicate include paths to the compiler - Removed version number for hermes in package.swift

Removed csettings which ends up as duplicate input to the compiler.

d4e1a08

Cleanup up targets and dependencies

c73ebc5

- Made deps named and not by reference (due to order of initialization) - Fixed issue in utils.js.

chrfalch force-pushed the @chrfalch/react-core-package-swift-update branch 2 times, most recently from 5b91784 to c73ebc5 Compare May 1, 2025 13:34

Merge branch 'main' into @chrfalch/react-core-package-swift-update

5cd29fe

cipolleschi reviewed May 7, 2025

View reviewed changes

chrfalch marked this pull request as ready for review May 7, 2025 16:06

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label May 7, 2025

facebook-github-bot closed this in 43bfb5d May 8, 2025

facebook-github-bot added the Merged This PR has been merged. label May 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[prebuild][iOS] building up to React Core #50766

[prebuild][iOS] building up to React Core #50766

Uh oh!

chrfalch commented Apr 16, 2025 •

edited

Loading

Uh oh!

cipolleschi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cipolleschi left a comment

Uh oh!

Uh oh!

cipolleschi Apr 29, 2025

Uh oh!

chrfalch Apr 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cipolleschi May 7, 2025

Uh oh!

chrfalch May 7, 2025

Uh oh!

cipolleschi May 7, 2025

Uh oh!

chrfalch May 8, 2025

Uh oh!

facebook-github-bot commented May 8, 2025

Uh oh!

facebook-github-bot commented May 8, 2025

Uh oh!

react-native-bot commented May 8, 2025

Uh oh!

Uh oh!

[prebuild][iOS] building up to React Core #50766

[prebuild][iOS] building up to React Core #50766

Uh oh!

Conversation

chrfalch commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cipolleschi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cipolleschi Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

chrfalch Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cipolleschi May 7, 2025

Choose a reason for hiding this comment

Uh oh!

chrfalch May 7, 2025

Choose a reason for hiding this comment

Uh oh!

cipolleschi May 7, 2025

Choose a reason for hiding this comment

Uh oh!

chrfalch May 8, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented May 8, 2025

Uh oh!

facebook-github-bot commented May 8, 2025

Uh oh!

react-native-bot commented May 8, 2025

Uh oh!

Uh oh!

chrfalch commented Apr 16, 2025 •

edited

Loading