Sync offset value to native immediately #50941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73622302 |
martinbooth
force-pushed
the
export-D73622302
branch
from
e340dee to
8b9887d
Compare
martinbooth
pushed a commit
to martinbooth/react-native
that referenced
this pull request
Apr 25, 2025
Summary: Without doing this, using Animated.event to update a value with an offset causes the value to revert to not having an offset because the native side doesn't even know about the offset if it hasn't been synced. Don't think there's a better place to sync this for the cases where an animation is kicked off entirely from the native side Changelog: [Android][Fixed] - Ensure latest offset value is synced to native Reviewed By: javache Differential Revision: D73622302
|
This pull request was exported from Phabricator. Differential Revision: D73622302 |
martinbooth
pushed a commit
to martinbooth/react-native
that referenced
this pull request
Apr 25, 2025
Summary: Pull Request resolved: facebook#50941 Without doing this, using Animated.event to update a value with an offset causes the value to revert to not having an offset because the native side doesn't even know about the offset if it hasn't been synced. Don't think there's a better place to sync this for the cases where an animation is kicked off entirely from the native side Changelog: [Android][Fixed] - Ensure latest offset value is synced to native Reviewed By: javache Differential Revision: D73622302
martinbooth
force-pushed
the
export-D73622302
branch
from
8b9887d to
39fa276
Compare
martinbooth
pushed a commit
to martinbooth/react-native
that referenced
this pull request
Apr 25, 2025
Summary: Without doing this, using Animated.event to update a value with an offset causes the value to revert to not having an offset because the native side doesn't even know about the offset if it hasn't been synced. Don't think there's a better place to sync this for the cases where an animation is kicked off entirely from the native side Changelog: [Android][Fixed] - Ensure latest offset value is synced to native Reviewed By: javache Differential Revision: D73622302
martinbooth
force-pushed
the
export-D73622302
branch
from
39fa276 to
d44cb9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73622302 |
martinbooth
pushed a commit
to martinbooth/react-native
that referenced
this pull request
Apr 25, 2025
Summary: Pull Request resolved: facebook#50941 Without doing this, using Animated.event to update a value with an offset causes the value to revert to not having an offset because the native side doesn't even know about the offset if it hasn't been synced. Don't think there's a better place to sync this for the cases where an animation is kicked off entirely from the native side Changelog: [Android][Fixed] - Ensure latest offset value is synced to native Reviewed By: javache Differential Revision: D73622302
martinbooth
force-pushed
the
export-D73622302
branch
2 times, most recently
from
360fa6e to
5cd6399
Compare
martinbooth
pushed a commit
to martinbooth/react-native
that referenced
this pull request
Apr 28, 2025
Summary: Without doing this, using Animated.event to update a value with an offset causes the value to revert to not having an offset because the native side doesn't even know about the offset if it hasn't been synced. Don't think there's a better place to sync this for the cases where an animation is kicked off entirely from the native side Changelog: [Android][Fixed] - Ensure latest offset value is synced to native Reviewed By: javache Differential Revision: D73622302
Summary: Pull Request resolved: facebook#50941 Without doing this, using Animated.event to update a value with an offset causes the value to revert to not having an offset because the native side doesn't even know about the offset if it hasn't been synced. Don't think there's a better place to sync this for the cases where an animation is kicked off entirely from the native side Changelog: [Android][Fixed] - Ensure latest offset value is synced to native Reviewed By: javache Differential Revision: D73622302
|
This pull request was exported from Phabricator. Differential Revision: D73622302 |
martinbooth
force-pushed
the
export-D73622302
branch
from
5cd6399 to
ce42e6c
Compare
|
This pull request has been merged in 3e3094c. |
|
This pull request was successfully merged by Martin Booth in 3e3094c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Without doing this, using Animated.event to update a value with an offset causes the value to revert to not having an offset because the native side doesn't even know about the offset if it hasn't been synced.
Don't think there's a better place to sync this for the cases where an animation is kicked off entirely from the native side
Changelog: [Android][Fixed] - Ensure latest offset value is synced to native
Reviewed By: javache
Differential Revision: D73622302