LINT-35(INTEGRATION): Move rule-configs close to tests

index.js

@@ -6,7 +6,7 @@ module.exports = {
         "sourceType": "module",
     },
     extends: [
-        path.resolve(__dirname, "./public-api-boundaries.js"),
-        path.resolve(__dirname, "./layers-slices-boundaries.js")
+        path.resolve(__dirname, "./rules/public-api-boundaries"),
+        path.resolve(__dirname, "./rules/layers-slices-boundaries")
     ],
 };

package.json

@@ -25,7 +25,7 @@
     "publish:minor": "npm version minor && npm publish",
     "publish:major": "npm version major && npm publish",
     "clean": "git clean -fxd",
-    "test": "mocha test/**.test.js"
+    "test": "mocha **/**.test.js"
   },
   "peerDependencies": {
     "eslint": ">=6",

layers-slices-boundaries.js → rules/layers-slices-boundaries/index.js

@@ -1,4 +1,4 @@
-const { getLowerLayers, FS_LAYERS } = require("./helpers");
+const { getLowerLayers, FS_LAYERS } = require("../../utils/helpers");
 
 const getLayersRules = () =>
     FS_LAYERS.map((layer) => ({

rules/layers-slices-boundaries/index.md

@@ -0,0 +1,19 @@
+# @feature-sliced/layers-slices-boundaries
+
+Reference: [Cross-communication](https://feature-sliced.design/docs/concepts/cross-communication)
+
+```js
+// 👎 Fail
+// 🛣 features/auth-form/index.ts
+import { getRoute } from "pages/auth";
+import { getStore } from "app/store";
+import { getAuthCtx } from "features/logout";
+import { UserAvatar } from "features/viewer-picker";
+
+// 👍 Pass
+// 🛣 features/auth-form/index.ts
+import { sessionModel } from "entities/session";
+import { Form, Button } from "shared/ui";
+import { getAuthCtx } from "entities/session";
+import { UserAvatar } from "entities/user";
+```

test/slices-boundaries.test.js → rules/layers-slices-boundaries/index.test.js

@@ -1,15 +1,14 @@
 const { ESLint } = require("eslint");
 const assert = require("assert");
-const { getRandomImportByLayerName } = require("./utils/tools");
-const { mockImports } = require("./utils/mock-import");
-const cfg = require("..");
+const { mockImports } = require("../../utils/mock-import");
+const cfg = require("./");
 
 const eslint = new ESLint({
     useEslintrc: false,
     baseConfig: mockImports(cfg),
 });
 
-describe("Import boundaries between slices", () => {
+describe("Import boundaries between slices and layers", () => {
 
     it("should lint with cross-import errors between pages.", async () => {
         const wrongImports = [
@@ -75,4 +74,29 @@ describe("Import boundaries between slices", () => {
 
         assert.strictEqual(report[0].errorCount, 0);
     });
+
+    it("should lint with cross-import errors.", async () => {
+        const wrongImports = [
+            `import { getRoute } from "pages/auth";`,
+            `import { getStore } from "app/store";`,
+        ];
+
+        const report = await eslint.lintText(wrongImports.join("\n"), {
+            filePath: "src/shared/lib/index.js",
+        });
+        assert.strictEqual(report[0].errorCount, wrongImports.length);
+    });
+
+    it("should lint without errors.", async () => {
+        const validCodeSnippet = [
+            `import { sessionModel } from "entities/session";`,
+            `import { Form, Button } from "shared/ui";`,
+        ].join("\n");
+
+        const report = await eslint.lintText(validCodeSnippet, {
+            filePath: "src/app/ui/app.js",
+        });
+        assert.strictEqual(report[0].errorCount, 0);
+    });
+
 });

public-api-boundaries.js → rules/public-api-boundaries/index.js

@@ -1,4 +1,4 @@
-const { getUpperLayers, FS_SEGMENTS, FS_LAYERS } = require("./helpers");
+const { getUpperLayers, FS_SEGMENTS, FS_LAYERS } = require("../../utils/helpers");
 
 const FS_SEGMENTS_REG = FS_SEGMENTS.join("|");
 const FS_LAYERS_REG = FS_LAYERS.join("|");

rules/public-api-boundaries/index.md

@@ -0,0 +1,24 @@
+# @feature-sliced/public-api-boundaries
+
+Reference: [PublicAPI](https://feature-sliced.design/docs/concepts/public-api)
+
+```js
+// 👎 Fail
+import { Issues } from "pages/issues/ui";
+import { IssueDetails } from "widgets/issue-details/ui/details"
+import { AuthForm } from "features/auth-form/ui/form"
+import { Button } from "shared/ui/button/button";
+import { saveOrder } from "entities/order/model/actions";
+import { orderModel } from "entities/order/model";
+import { TicketCard } from "@/entities/ticket/ui";
+
+// 👍 Pass
+import { Issues } from "pages/issues";
+import { IssueDetails } from "widgets/issue-details"
+import { AuthForm } from "features/auth-form"
+import { Button } from "shared/ui/button";
+import { orderModel } from "entities/order";
+import { TicketCard } from "@/entities/ticket";
+import { AuthForm } from "features/auth/form"
+import { Button } from "shared/ui";
+```

test/public-api-boundaries.test.js → rules/public-api-boundaries/index.test.js

@@ -1,7 +1,7 @@
 const { ESLint } = require("eslint");
 const assert = require("assert");
-const { mockImports } = require("./utils/mock-import");
-const cfg = require("../public-api-boundaries");
+const { mockImports } = require("../../utils/mock-import");
+const cfg = require("./");
 
 const eslint = new ESLint({
     useEslintrc: false,