Skip to content

fix: Fix inputs parsing when ctx.inputs is undefined. #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025

Conversation

batk0
Copy link
Contributor

@batk0 batk0 commented Apr 23, 2025

A tiny fix for parsing inputs. It's for the case when spec.inputs are specified in main .gitlab-ci.yml with defaults and no inputs provided for the job.

Example:

---
spec:
  inputs:
    foo:
      type: string
      default: bar
---
job:
  script:
    - echo $[[ inputs.foo ]]

@batk0 batk0 changed the title Fix inputs parsing when ctx.inputs is undefined. fix: Fix inputs parsing when ctx.inputs is undefined. Apr 23, 2025
@ANGkeith
Copy link
Collaborator

@batk0 could you fix the failing test

other than that lgtm

@batk0
Copy link
Contributor Author

batk0 commented Apr 25, 2025

@ANGkeith Done

@batk0 batk0 force-pushed the fix_inputs_indexing branch from 7f769bd to b55166b Compare April 25, 2025 16:41
@ANGkeith ANGkeith merged commit efac182 into firecow:master Apr 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants