Skip to content

Update the ModeSolver by adding perturbation-based group index and group velocity dispersion calculatoion method #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Update the ModeSolver by adding perturbation-based group index and group velocity dispersion calculatoion method #2243

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6e6fda9
Update the ModeSolver by adding perturbation-based group index and gr…
vasilyzabelin Feb 7, 2025
66034f6
Merge remote-tracking branch 'origin/develop' into vasily/modesolver/GVD
vasilyzabelin Feb 12, 2025
41f1727
maint[web]: Use default S3 TransferConfig for up/downloads
yaugenst-flex Feb 4, 2025
ff48067
maint[web]: Use default S3 TransferConfig for up/downloads
yaugenst-flex Feb 4, 2025
bb2f049
maint[web]: Use default S3 TransferConfig for up/downloads
yaugenst-flex Feb 4, 2025
b7be048
maint[web]: Use default S3 TransferConfig for up/downloads
yaugenst-flex Feb 4, 2025
39c7b01
maint[web]: Use default S3 TransferConfig for up/downloads
yaugenst-flex Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tidy3d/components/mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,14 @@ class ModeSpec(Tidy3dBaseModel):
f"default of {GROUP_INDEX_STEP} is used.",
)

calculate_group_index: bool = pd.Field(
False,
title="Pertuirbation-based calculationof the group index and the GVD",
description="Control the computation of the group index and the group velocity dispersion"
"alongside the effective index. If set to 'True', the perturbation theory based alggorithm"
" is used for calculation.",
)

@pd.validator("bend_axis", always=True)
@skip_if_fields_missing(["bend_radius"])
def bend_axis_given(cls, val, values):
Expand Down
Loading
Loading