Unsteady heat support #2388
Unsteady heat support #2388
Conversation
marc-flex
force-pushed
the
marc/unsteady-heat
branch
from
8c094ee to
cdd748a
Compare
There was a problem hiding this comment.
a couple of big picture comments:
-
Not sure about having output frequency as a parameter in
UnsteadySpec. I think it could be more useful if sampling frequency can be defined for each monitor separately, similar to fdtd time monitors. Say, if I want to have just few snapshots in time for a big monitor, but then also record temperature for each step at a given point. -
For initial condition, I imagine at some point we might need to extend it to non-uniform distribution. While I would say this is out of scope for this PR, I think it would be worth ironing out how that would look like. I see two options
initial_temperature: Union[pd.PositiveFloat, SpatialDataArray, UnstructuredGridDataset]initial_temperature: Union[UniformDistibution, CustomDistribution]
probably the first option is a way to go, unless I am missing something that would require introduction of new specs?
Adding support for unsteady heat simulations.