Skip to content

[CQ] remove FlutterCreateAdditionalSettingsField deadcode #8207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented May 20, 2025

Following up on a TODO from Steve to remove an unused method and callers.

Interestingly, FlutterModuleGroup seems entirely unused. It's meant to:

// Define a group of Flutter project types for use in Android Studio 4.2 and later.

Steve warns:

// TODO (messick) DO NOT delete this during post-4.2 clean-up.

but maybe we can? Especially if noone has plans to re-integrate.

@jwren : do you have any context on this?


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from jwren May 20, 2025 18:33
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but do build and test it on both Meerkat and Narwhal before landing, smaller changes than this have caused a number of issues with this project.

@pq pq merged commit 9bd3842 into flutter:master May 20, 2025
7 checks passed
@pq pq deleted the cq_FlutterModuleGroup_deadCode branch May 20, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants