#1420 : add platform definition macros #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancientjpeg
commented
Apr 8, 2025
dev/functional/config.h
Outdated
Comment on lines
88
to
93
| #elif defined(__linux__) | ||
| #if defined(__ANDROID__) | ||
| #define SQLITE_ORM_ANDROID | ||
| #endif | ||
| #define SQLITE_ORM_LINUX | ||
| #define SQLITE_ORM_UNIX |
There was a problem hiding this comment.
__linux__ should always be defined on android systems so I figured this was safe.
|
Sorry about the multiple commits in rapid succession there—just a heads up, |
trueqbit
reviewed
Apr 13, 2025
|
Hey @trueqbit, I've implemented those changes you asked for. |
fnc12
approved these changes
Apr 18, 2025
trueqbit
requested changes
Apr 19, 2025
trueqbit
approved these changes
Apr 24, 2025
|
Thx @ancientjpeg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1420.
Notes
SQLITE_ORM_IOSwill be defined for all ofiOS|watchOS|tvOSwhich I believe is suitable as they share very similar OS APIs. There should be virtually no difference from the perspective of this library, so it'll be up to users to make those differentiations if they need to.