Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: initial implementation #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial implementation #1
Changes from all commits
b2514c5
1873019
f310a98
c6fe98f
62d5035
78e8ec1
0bb961c
138911b
0aeba42
47d47dd
ce4d38e
8a5c921
48004b6
e95c61e
98afcb9
4b351a8
1b1c616
985cff2
d9afb37
1654736
ea4d56b
e29f1a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you install directly from the tgz?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cleanup hook needs a consistent name.
pack
names the file with the version so it isn't stable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reasoning around this over 0.0.0? I don't have strong opinions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semantic release will use
1.0.x
as the current version if you specify0.0.0
. There's probably a way to override that with config but using0.1.0
as the base seemed like a reasonable trade off.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean by this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at https://github.com/functionless/create-functionless/pull/1/files#diff-b3dcca123bc557a15a933374361c741e8f04f515436c7aaa8f9fa89618f6c4c8
If I were to keep the name as
.gitignore
instead of.gitignore.template
, npm would drop this file from its packaging process and rendering the template would fail due to missing a file from the manifest. As far as I can tell, this behavior cannot be overridden.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: provide a helper or use
\n