test(replay): Rewrite custom matcher to be recognized by VSCode #16141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Apr 28, 2025
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| import '../utils/mock-internal-setTimeout'; | |||
| import { captureException, getClient } from '@sentry/core'; | |||
| import type { MockInstance } from 'vitest'; | |||
There was a problem hiding this comment.
e.g. this was not imported but still worked, for whatever reason? Now it "correctly" complained about this.
mydea
commented
Apr 28, 2025
| @@ -34,15 +35,15 @@ async function waitForFlush() { | |||
| } | |||
|
|
|||
| describe('Integration | errorSampleRate', () => { | |||
| beforeAll(() => { | |||
There was a problem hiding this comment.
unrelated but also incorrect how it was, oops.
mydea
commented
Apr 28, 2025
| @@ -163,14 +164,14 @@ describe('Integration | errorSampleRate', () => { | |||
| const ADVANCED_TIME = 86400000; | |||
| const optionsEvent = createOptionsEvent(replay); | |||
|
|
|||
| expect(replay.session.started).toBe(BASE_TIMESTAMP); | |||
| expect(replay.session?.started).toBe(BASE_TIMESTAMP); | |||
There was a problem hiding this comment.
this was also incorrectly not flagged?? weird..
mydea
commented
Apr 28, 2025
| @@ -364,24 +365,6 @@ describe('Integration | errorSampleRate', () => { | |||
| }, | |||
| ]), | |||
| }); | |||
|
|
|||
| vi.advanceTimersByTime(DEFAULT_FLUSH_MIN_DELAY); | |||
There was a problem hiding this comment.
just removed this because it actually irrelevant to this specific test.
There was a problem hiding this comment.
Does this behavior get covered in another test?
billyvg
approved these changes
Apr 28, 2025
| @@ -364,24 +365,6 @@ describe('Integration | errorSampleRate', () => { | |||
| }, | |||
| ]), | |||
| }); | |||
|
|
|||
| vi.advanceTimersByTime(DEFAULT_FLUSH_MIN_DELAY); | |||
There was a problem hiding this comment.
Does this behavior get covered in another test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was always annoyed that this was not properly highlighted by VSCode, so I looked into this a bit, and actually refactored it a bit to be more type-safe in the vitest world we now live in :)
I got rid of
toHaveSentReplayin favor of simply always usingtoHaveLastSentReplay(which we already used almost everywhere). I also moved the type definition into a separate file and ensured it actually works, at leas tin my vscode/cursor instance. This also kind of surfaced some type errors that existed in tests, but have not been shown (??) for whatever reason... no idea what is going on there.