Skip to content

test(e2e): Pin @shopify/mini-oxygen to 3.2.0 to fix build error #16158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 29, 2025

Seems like @shopify/mini-oxygen@3.2.1 breaks something. I somewhat suspect that they bumped a vite version but I didn't find a changelog yet

This should unblock the PRs we want to include in Today's release

Update: Shopify/hydrogen#2863 likely caused this

@Lms24 Lms24 requested a review from chargome April 29, 2025 12:14
@Lms24 Lms24 self-assigned this Apr 29, 2025
@Lms24 Lms24 requested a review from timfish April 29, 2025 12:14
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking a look 🙏

@Lms24 Lms24 enabled auto-merge (squash) April 29, 2025 12:16
@Lms24 Lms24 disabled auto-merge April 29, 2025 13:49
@Lms24 Lms24 force-pushed the lms/test-e2e-fix-hydrogen-dep branch from 4844d1e to e963e42 Compare April 29, 2025 13:52
@Lms24 Lms24 enabled auto-merge (squash) April 29, 2025 13:53
@Lms24 Lms24 merged commit 83f7f52 into develop Apr 29, 2025
157 checks passed
@Lms24 Lms24 deleted the lms/test-e2e-fix-hydrogen-dep branch April 29, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants