feat(aci): Only update open periods if the initial one exists #90079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
commented
Apr 22, 2025
Comment on lines
+1718
to
+1720
| if features.has( | ||
| "organizations:issue-open-periods", group.project.organization | ||
| ) and has_initial_open_period(group): |
There was a problem hiding this comment.
Sorry for the larger diff - calling out the logic changes
snigdhas
commented
Apr 22, 2025
| @@ -1063,185 +1061,3 @@ def pre_save_group_default_substatus(instance, sender, *args, **kwargs): | |||
| "No substatus allowed for group", | |||
| extra={"status": instance.status, "substatus": instance.substatus}, | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
all of this is moved to groupopenperiod.py
snigdhas
commented
Apr 22, 2025
Comment on lines
+215
to
+218
| # Until we've backfilled the GroupOpenPeriod table, we don't want to update open periods for | ||
| # groups that weren't initially created with one. | ||
| if not has_initial_open_period(group): | ||
| return |
There was a problem hiding this comment.
the other bit of new logic, along with the function def at the end of the file
snigdhas
commented
Apr 22, 2025
Comment on lines
+261
to
+262
| def has_initial_open_period(group: Group) -> bool: | ||
| return GroupOpenPeriod.objects.filter(group=group, date_started__lte=group.first_seen).exists() |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #90079 +/- ##
========================================
Coverage 87.64% 87.65%
========================================
Files 10250 10260 +10
Lines 577029 577652 +623
Branches 22719 22719
========================================
+ Hits 505725 506321 +596
- Misses 70861 70888 +27
Partials 443 443 |
wedamija
reviewed
Apr 22, 2025
|
whoops, added tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 to get us ready for the open period backfill
In order to cleanly backfill open periods, we need to change the existing open period logic to only update an open period for a group if the group has the initial open period (from group creation). If it doesn't, then do nothing. If it does, handle the open periods as usual.
This PR makes that change, using
has_initial_open_periodto check for an open period that matches thegroup.first_seentime.I've also relocated all the open period methods to
groupopenperiod.pyinstead ofgroup.py.