feat(trace-eap-waterfall): Cleaning up trace context sections #90091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
Apr 22, 2025
Abdkhan14
commented
- Only rendering contexts when we have data to populate them with.
- Disabled collapse persistence for the context sections.
github-actions
bot
added
the
Scope: Frontend
edwardgou-sentry
approved these changes
Apr 23, 2025
| key="logs" | ||
| type={TraceContextSectionKeys.LOGS} | ||
| <FoldSection | ||
| sectionKey={TraceContextSectionKeys.LOGS as string as SectionKey} |
There was a problem hiding this comment.
Should we be adding these to SectionKey? I noticed there were a few more keys in the PR that were being forced to SectionKey
Comment on lines
30
to
35
| const hasProfiles = tree.type === 'trace' && tree.profiled_events.size > 0; | ||
| const hasLogs = logs && logs?.length > 0; | ||
| const hasTags = | ||
| rootEvent.data && | ||
| rootEvent.data.tags.length > 0 && | ||
| !(tree.type === 'empty' && hasLogs); // We don't show tags for only logs trace views |
There was a problem hiding this comment.
nit: might be useful to break this out into a shareable function. Looks like the same logic is being used somewhere else in this pr too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.