Skip to content

ref(grouping): Small enhancements refactors #90101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2025

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Apr 22, 2025

This is a series of small refactors to enhancements code, extracted from upcoming PRs in order to make them easier to review. No behavior changes.

  • Break the base64 helper functions up into more steps.
  • Pull the rust exception data into its own variable before passing it to the rust enhancer.
  • Remove Enhancements.as_dict and the EnhancementsDict type. These used to be used in the /grouping-enhancements endpoint, but it was removed 4 years ago in ref(grouping): No longer expose enhancement bases for upgrading #24854.
  • Clean up enhancement tests (mostly adding/organizing helper functions and fixtures).

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 22, 2025
@lobsterkatie lobsterkatie force-pushed the kmclb-small-enhancements-refactors-april-2025 branch from eeb6044 to c924908 Compare April 22, 2025 21:04
@lobsterkatie lobsterkatie marked this pull request as ready for review April 22, 2025 21:28
@lobsterkatie lobsterkatie requested a review from a team as a code owner April 22, 2025 21:28
@lobsterkatie lobsterkatie force-pushed the kmclb-small-enhancements-refactors-april-2025 branch from c924908 to ec78f79 Compare April 23, 2025 18:43
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 99.14530% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/sentry/grouping/test_enhancer.py 99.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #90101      +/-   ##
==========================================
+ Coverage   85.44%   87.72%   +2.28%     
==========================================
  Files       10247    10248       +1     
  Lines      578490   578483       -7     
  Branches    22696    22696              
==========================================
+ Hits       494269   507486   +13217     
+ Misses      83778    70554   -13224     
  Partials      443      443              

@lobsterkatie lobsterkatie merged commit 8adbf74 into master Apr 23, 2025
65 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-small-enhancements-refactors-april-2025 branch April 23, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants