ref(dashboards): Update TimeSeries timestamp types
#90104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DAIN-361: Change
TimeSeriestimestampfield to be an integer. This PR helps align theTimeSeriestype to the response format of the/events-timeseries/endpoint. This PR changes thetimestampfield everywhere that's relevant to use numbers instead of strings.The main changes are to the fixtures and stories, where we generate the data. The other changes are to the conversion functions we use to convert the current endpoint responses to
TimeSeries. The important part here is thatDate()accepts strings and integers, so the type safety doesn't necessarily save us. Especially since it wants millisecond timestamps!Integer timestamps are a little harder to read when debugging, but they're much easier to use when creating dates, shifting them by offsets, comparing them, sorting them, etc.