Fix typed splat function parameters in Python. #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #476.
Eliding the
identifier
node type in the stanza query allows it to erroneously matchlist_splat_pattern
ordictionary_splat_pattern
when those appear within atyped_parameter
. This causes the stack graph generation to fail with an error:The fragment of the parsed Tree-sitter tree for such a parameter is:
As of v0.23.5 of the Python grammar,
typed_parameter
may containidentifier
or either of the*_splat_pattern
node types. As such, making theidentifier
node type explicit fixes the issue precisely without introducing other problems.