Fix superclass keyword arguments in Python. #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python supports keyword arguments in its
superclasses: (argument_list …)
, which somehow modify the superclass. The stanza capturing superclasses was erroneously capturing these keyword arguments as superclasses themselves as well, which would then cause an error upon emitting the edge:The fragment of the parsed Tree-sitter tree for such a superclass argument list with keyword arguments is:
As of v0.23.5 of the Python grammar, the
superclasses
field is indeed anargument_list
syntax node, which in turn can contain either anexpression
or akeyword_argument
(among other things), andexpression
in turn can be a whole host of types of syntax nodes.Explicitly capturing only
identifier
andattribute
(which are dotted identifier chains likefoo.bar
) syntax nodes fixes the issue. This is possibly too strict, since technically any expression can be used here, but it likely captures the vast majority of cases out there.