Fix instantiation expr. args. in TypeScript. #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instantiation_expression
syntax nodes were not included in the list of basic expressions, and thus the@expr.lexical_scope
graph node was not being created for them. This caused an error in the stanza that deals with function arguments, e.g.:Simply including
instantiation_expression
syntax nodes in the list fixe the issue. Copious testing (on our TS test suite and on all of microsoft/vscode) reveals no negative side effects.Actually resolving a reference appearing in an instantiation expression as call argument does not work — I left a
TODO
.